test for learn more button color param #31
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gurugopinath85
requested review from
Kevinloritsch,
mailynnguyen and
abhnv-shrma
and removed request for
abhnv-shrma
mailynnguyen
requested changes
Oct 13, 2024
There was a problem hiding this comment.
Hey Guru, good work. However, there are a few revisions that we would like:
- Instead of svg tags, please use lucide react icons
- Please use tailwind css instead of css
- Also, you can just use the normal arrow function component, so something like this: const LearnMoreButton = ({ color }) => {}
- And change the name of the file to be capitalized, so something like: LearnMoreButton.tsx
Also, the button more me looks like this:
Really good work, please send us a message if you need any clarification or help.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Testing out PR for learn more button with color. Definitely not completed but trying to figure my way around the PRS and the code I have completed. The way I have set up the code is so that a learn more button can be added, and color changes.